hussein-awala commented on code in PR #61376:
URL: https://github.com/apache/airflow/pull/61376#discussion_r2760144138
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -359,11 +359,11 @@ def trigger_tasks(self, open_slots: int) -> None:
:param open_slots: Number of open slots
"""
- sorted_queue = self.order_queued_tasks_by_priority()
+ sorted_queue = deque(self.order_queued_tasks_by_priority())
Review Comment:
I believe this should be solved differently, as the reverse order doesn't
make sense, we can sort the tasks in ascending order and pop from the end of
the list here (which is O(1))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
