SameerMesiah97 commented on code in PR #61391:
URL: https://github.com/apache/airflow/pull/61391#discussion_r2760496135
##########
providers/google/tests/unit/google/cloud/operators/test_gen_ai.py:
##########
@@ -235,6 +236,33 @@ def test_execute(self, mock_hook):
config=None,
)
+ @mock.patch(GEN_AI_PATH.format("GenAIGenerativeModelHook"))
+ def test_execute_exception(self, mock_hook):
Review Comment:
Nit: I would suggest renaming this to
`test_execute_propagates_client_error`. Current name is acceptable but this
would make the intention behind the test more explicit. This suggestion is
non-blocking.
##########
providers/google/tests/unit/google/cloud/operators/test_gen_ai.py:
##########
@@ -235,6 +236,33 @@ def test_execute(self, mock_hook):
config=None,
)
+ @mock.patch(GEN_AI_PATH.format("GenAIGenerativeModelHook"))
+ def test_execute_exception(self, mock_hook):
+ """Test that GenAICountTokensOperator propagates exceptions from the
hook."""
Review Comment:
If you proceed with updating the name, I would update the docstring as well.
I would suggest the following:
`"""Test that GenAICountTokensOperator propagates ClientError from the
hook."""`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
