Miretpl commented on code in PR #61018:
URL: https://github.com/apache/airflow/pull/61018#discussion_r2760863117
##########
chart/templates/check-values.yaml:
##########
@@ -21,6 +21,14 @@
The sole purpose of this YAML file is it to check the values file is
consistent for some complex combinations.
*/ -}}
+{{- /*
+##############################
+ Version checks
+#############################
+*/ -}}
+ {{- if semverCompare "<2.11.0" .Values.airflowVersion }}
+ {{ required "This chart only supports Airflow version 2.11.0 and above."
nil }}
Review Comment:
```suggestion
{{ required "This chart only supports Apache Airflow version 2.11.0 and
above." nil }}
```
##########
helm-tests/tests/helm_tests/security/test_rbac.py:
##########
@@ -112,13 +112,8 @@ def _is_airflow_3_or_above(self, version):
def _get_object_tuples(self, version, sa: bool = True):
tuples = copy(DEPLOYMENT_NO_RBAC_NO_SA_KIND_NAME_TUPLES)
- if version in {"default", "3.0.0"}:
- tuples.append(("Service", "test-rbac-triggerer"))
- tuples.append(("StatefulSet", "test-rbac-triggerer"))
- else:
- tuples.append(("Deployment", "test-rbac-triggerer"))
- if version == "2.3.2":
- tuples.append(("Secret", "test-rbac-result-backend"))
+ tuples.append(("Service", "test-rbac-triggerer"))
+ tuples.append(("StatefulSet", "test-rbac-triggerer"))
Review Comment:
If it is always appended, maybe we could add it directly to the
`DEPLOYMENT_NO_RBAC_NO_SA_KIND_NAME_TUPLES` tuple?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
