jscheffl commented on code in PR #57610: URL: https://github.com/apache/airflow/pull/57610#discussion_r2761040480
########## providers/informatica/src/airflow/providers/informatica/plugins/listener.py: ########## @@ -0,0 +1,191 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging +from typing import TYPE_CHECKING + +from airflow import settings +from airflow.listeners import hookimpl +from airflow.providers.informatica.extractors import InformaticaLineageExtractor +from airflow.providers.informatica.hooks.edc import InformaticaEDCHook + +if TYPE_CHECKING: + from airflow.models import TaskInstance + from airflow.utils.state import TaskInstanceState + +_informatica_listener: InformaticaListener | None = None + + +def _executor_initializer(): + """ + Initialize processes for the executor used with DAGRun listener's methods (on scheduler). + + This function must be picklable, so it cannot be defined as an inner method or local function. + + Reconfigures the ORM engine to prevent issues that arise when multiple processes interact with + the Airflow database. + """ + # This initializer is used only on the scheduler + # We can configure_orm regardless of the Airflow version, as DB access is always allowed from scheduler. + settings.configure_orm() + Review Comment: Why is ORM being initialized in provider? I assume if running in executor context you should assume ORM is initialized. If it would not be at point of reaching here then something is wrong. I'd rather remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
