pierrejeambrun commented on code in PR #61043: URL: https://github.com/apache/airflow/pull/61043#discussion_r2762779731
########## airflow-core/tests/unit/api_fastapi/core_api/test_app.py: ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import pytest + +from tests_common.test_utils.db import clear_db_jobs + +pytestmark = pytest.mark.db_test + + +class TestGzipMiddleware: + @pytest.fixture(autouse=True) + def setup(self): Review Comment: Not sure why we need that setup function. ########## airflow-core/src/airflow/api_fastapi/core_api/app.py: ########## @@ -185,3 +180,9 @@ def init_middlewares(app: FastAPI) -> None: from airflow.api_fastapi.auth.managers.simple.middleware import SimpleAllAdminMiddleware app.add_middleware(SimpleAllAdminMiddleware) + + # The GzipMiddleware should be the last middleware added as https://github.com/apache/airflow/issues/60165 points out. + app.add_middleware(GZipMiddleware, minimum_size=1024, compresslevel=5) + # Compress responses greater than 1kB with optimal compression level as 5 + # with level ranging from 1 to 9 with 1 (fastest, least compression) + # and 9 (slowest, most compression) Review Comment: This comment is probably missplaced and should be above the GZipMiddleware line. ########## airflow-core/tests/unit/api_fastapi/core_api/test_app.py: ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import pytest + +from tests_common.test_utils.db import clear_db_jobs + +pytestmark = pytest.mark.db_test Review Comment: Not sure why it's marked as a db test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
