avolant commented on PR #61362: URL: https://github.com/apache/airflow/pull/61362#issuecomment-3847297997
I removed 4 broken unit tests for the redis import in c57aaef323ddfd1a236e02f9156fbbf3ff86dce3 **Why the tests failed:** - `test_send_task_to_executor_*`: Used `["command"]` as 2nd tuple element, but Airflow 3.0+ expects a `BaseWorkload` with `.model_dump_json()` → `AttributeError: 'list' object has no attribute 'model_dump_json'` - `test_*_handles_missing_redis`: Used `__builtins__.__import__` which is a dict in pytest context (module only in `__main__`) → `AttributeError: 'dict' object has no attribute '__import__'` **Why we don't need them:** - The fix is 4 lines: `try: import redis.client except ImportError: pass` - Integration tests (`test_celery_executor_integration.py`) already validate Redis works with the executor - Unit testing a bare try/except around an import adds no value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
