Fury0508 commented on PR #60193: URL: https://github.com/apache/airflow/pull/60193#issuecomment-3851804717
Hi @bugraoz93! 👋 Finally got it working! 🎉 The positional parameters implementation is now complete with proper default value detection. ## What was fixed: - Extracts `has_default` from function signatures via AST - Makes primitive parameters positional only if: not boolean AND no default value AND not in special list operations - Special handling for `dagrun.list` and `jobs.list` (all params optional despite no defaults in operations.py) - Updated integration tests to match the correct syntax ## Key changes: - `assets get 1` (positional) - `xcom add dag_id dag_run_id task_id key value` (`map_index` is optional due to default) - `dagrun list --dag-id=... --state=...` (all optional) - `connections create conn_id conn_type` (required Pydantic fields positional) Sorry for so many commits - this took more iterations than expected to get all the edge cases right! 😅 The implementation should now correctly handle all scenarios. Ready for review whenever you have time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
