stegololz commented on code in PR #61351:
URL: https://github.com/apache/airflow/pull/61351#discussion_r2770287634


##########
providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py:
##########
@@ -367,9 +390,24 @@ def _is_authorized(
         elif method == "GET":
             method = "LIST"
 
+        is_multi_team = conf.getboolean("core", "multi_team", fallback=False)

Review Comment:
   `        if is_multi_team and is_team_scoped and is_teamless and method != 
"LIST":` 
   
   This now raise an error. 
   
   `        if is_multi_team and is_team_scoped and is_teamless and method == 
"LIST":`
   
   This case happens, so I would like to keep like like this (e.g. when it 
comes from 
https://github.com/apache/airflow/blob/b906080fe82cd72c9024dd62cf1b64c15f403ed8/airflow-core/src/airflow/api_fastapi/core_api/security.py#L148-L168
 )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to