dabla commented on code in PR #61188:
URL: https://github.com/apache/airflow/pull/61188#discussion_r2777225340
##########
providers/google/src/airflow/providers/google/cloud/transfers/adls_to_gcs.py:
##########
@@ -117,7 +119,21 @@ def __init__(
google_impersonation_chain: str | Sequence[str] | None = None,
**kwargs,
) -> None:
- super().__init__(path=src_adls,
azure_data_lake_conn_id=azure_data_lake_conn_id, **kwargs)
+ file_system_name = kwargs.pop("file_system_name", None)
Review Comment:
@shahar1 Wouldn't it be better to have this logic in a (static) method
validate_kwargs which we unpack in constructor like so we don't pollute the
constuctor with code before invoking to super one?
```python
super().__init__(
file_system_name=file_system_name,
path=src_adls,
azure_data_lake_conn_id=azure_data_lake_conn_id,
**validate_kwargs(kwargs),
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
