jscheffl commented on PR #57610: URL: https://github.com/apache/airflow/pull/57610#issuecomment-3864351682
> Static Checks / Pre-commit: When I run pre-commit locally, it modifies some breeze files and removes the version information for the Informatica provider in pyproject.toml. I was hesitant to include these auto-generated changes in my commit. Is this behavior expected? Should I commit these changes? > > OpenLineage Test: The test_extractor_manager_calls_appropriate_extractor_method in OpenLineage tests is failing. I am not sure if my provider triggered this issue. Should I update the assertion in that test to fix it? > > Core Plugin Test: The TestGetPlugins::test_should_respond_200 test is failing because the total plugin count has changed (due to my new plugin). I tried to avoid modifying core files, but in this case, should I update the test to reflect the new plugin count? With the static checks I am not 100% sure. It might be a new "chicken and egg" problem. @potiuk do you know why version is removed? I assume a follow-up PR after merging is needed to add the version number. Regarding core tests you most probably adjust the counts to get tests green. I would see an improvement of CI not having dependencies to current provider source tree outside of this PR and as a general improvement of CI needed. With OpenLineage I am not sure, I am not in this topic :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
