Subham-KRLX commented on code in PR #61105: URL: https://github.com/apache/airflow/pull/61105#discussion_r2777544421
########## airflow-ctl-tests/tests/airflowctl_tests/test_config_sensitive_masking.py: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import pytest + +# Test commands for config sensitive masking verification +SENSITIVE_CONFIG_COMMANDS = [ + # Test that config list shows masked sensitive values + "config list", + # Test that getting specific sensitive config values are masked + "config get --section core --option fernet_key", + "config get --section database --option sql_alchemy_conn", +] + + [email protected](reruns=3, reruns_delay=1) Review Comment: Thanks for catching both issues Removed the flaky decorator and fixed the CI discovery - the root cause was a hardcoded path in run_tests.py that only ran test_airflowctl_commands.py. Fixed in 5fc6243 test should now be picked up by CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
