shahar1 commented on PR #61342: URL: https://github.com/apache/airflow/pull/61342#issuecomment-3867444217
> Do i have to change something in this PR? > I'd suggest to start by understanding the issue you're trying to solve, and what components could be affected by it. It could be only API, but it could also be a UI - so you should check it deeply (it could involve tries and errors, that's part of the process). Then, when you're certain of the cause - implement the solution and check that it works (unit tests, manual E2E tests, and for UI there are automated E2E tests as well). Make sure to include at least the unit tests in the PR (tip: they should fail without the changes in the source code being implemented). After doing all of the above, commit, push, and update the PR's description - as currently it doesn't reflect what's going on (if you use AI, my comments above are still valid). If you're struggling with adding automated E2E tests, please also include screenshots/video that will prove that the issues are solved. To review it, I need to be convinced that your PR actually solves the issue, and doesn't cause others on the way. If this issue is too challenging (it was not labeled as a `good first issue`) - there are other issues that you are welcome to try. Good luck! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
