yulit0738 opened a new pull request, #61655:
URL: https://github.com/apache/airflow/pull/61655
**Summary**
Fixes two bugs in `OtelTrace` that cause scheduler crashes when processing
tasks with NULL or empty `context_carrier`.
Bug 1: `OtelTrace.extract(None)` crashes with AttributeError
- **Symptom**: `AttributeError: 'NoneType' object has no attribute 'get'`
- **Cause**: When `context_carrier` is NULL in DB (tasks created before OTel
was enabled, then cleared/backfilled),
`TraceContextTextMapPropagator().extract(carrier)` calls `carrier.get()` which
fails.
- **Fix**: Return empty dict `{}` when carrier is `None`.
Bug 2: `OtelTrace.start_child_span()` crashes with StopIteration
- **Symptom**: `StopIteration` exception
- **Cause**: When `context_carrier` is `{}` (empty dict), `extract()`
returns an empty `Context` object. `next(iter(parent_context.values()))` raises
`StopIteration` on empty iterator.
- **Fix**: Use `next(..., None)` with default value and guard the
`isinstance` check.
Both bugs are triggered in `base_executor.py:trigger_tasks()` when the
scheduler enqueues a task whose `dag_run.context_carrier` is `None` or empty.
Reproduction Path
1. Enable OTel tracing on an existing Airflow deployment
2. Tasks/dag_runs created before OTel was enabled have `context_carrier =
NULL`
3. Clear or backfill those tasks
4. Scheduler crashes in `base_executor.py:trigger_tasks()` → `workloads.py`
→ `Trace.extract()`
Testing
- Added unit tests:
`shared/observability/tests/observability/traces/test_otel_tracer.py`
- All 6 tests passed in Breeze
- Verified fix in production Airflow 3.1.6 environment
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude (Anthropic) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
