dheerajturaga commented on code in PR #56456:
URL: https://github.com/apache/airflow/pull/56456#discussion_r2780564964
##########
scripts/ci/prek/compile_provider_assets.py:
##########
@@ -56,6 +56,10 @@
"hash": PROVIDERS_ROOT / "edge3" / "www-hash.txt",
},
}
+PROVIDERS_BUILD = {
+ "fab": "yarn",
+ "edge": "pnpm",
+}
Review Comment:
nit, Make PROVIDERS_BUILD encode the full commands instead of just the
package manager name, so there's no inline conditional logic ?
```suggestion
PROVIDERS_BUILD = {
"fab": {
"install": ["yarn", "install", "--frozen-lockfile"],
"build": ["yarn", "run", "build"],
},
"edge": {
"install": ["pnpm", "install", "--frozen-lockfile"],
"build": ["pnpm", "build"],
},
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
