Nataneljpwd commented on PR #61527:
URL: https://github.com/apache/airflow/pull/61527#issuecomment-3873439068

   > in opotion 2, i did not add it, but it would go like
   > 
   > * airflow.apache.org/connection-name
   > * airflow.apache.org/variable-name
   > * airflow.apache.org/config-name
   > 
   > as per maintainig uniquness on secrets/labels, this is not a backend role 
to maintain proper secrets deployment, secrets backend reads connections, if 
the connections are wrongly deployed to a namespace this is a totally different 
problem (this is how I see it )
   
   So it would have a hardcoded label prefix plus a name for the 
connection/variable/config, alright, seems reasonable and probably a good Idea, 
yet I still don't understand what is a 'config'? is it an airflow 
configuration? as I do not know about  any airflow object of type config other 
than the core airflow configuration, which from what I remember, cannot be 
pulled at runtime.
   
   Option 1 still seems like the better option, as in my opinion it will look 
cleaner in code rather than using formatted strings in a bunch of places, but 
it is not a must, nor is it a blocker from my side, just personal preference.
   
   Any of the options, 1 or 2 will suffice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to