Nataneljpwd commented on PR #61527: URL: https://github.com/apache/airflow/pull/61527#issuecomment-3880837573
> One more thing I am still not sure on, how to approach - the default label names, I use the consistent across all three types: > > ``` > airflow.apache.org/connection-name > airflow.apache.org/variable-name > airflow.apache.org/config-name > ``` > > however looking on the naming conventions in airflow, maybe this should go like: > > ``` > airflow.apache.org/connection-id -> get_conn_value(self, conn_id: str, team_name: str | None = None) > airflow.apache.org/variable-key -> get_variable(self, key: str, team_name: str | None = None) > airflow.apache.org/config-key -> get_config(self, key: str) > ``` Looks good, supporting multi team is a very good idea and I don't know how I missed it, as I really look forward for the feature, I think that sticking to the airflow convention will make it more readable and intuitive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
