dominikhei commented on PR #52770: URL: https://github.com/apache/airflow/pull/52770#issuecomment-3884626208
> > The sensor currently doesn't have deferrable capability. Do we expect this functionality to work well with defer mode when implemented? > > In that case, if `deferrable == True` the retries could be passed to the trigger, or? E.g looking at the BatchSensor example: > > ``` > self.defer( > timeout=timeout, > trigger=BatchJobTrigger( > job_id=self.job_id, > aws_conn_id=self.aws_conn_id, > region_name=self.region_name, > waiter_delay=int(self.poke_interval), > waiter_max_attempts=self.max_retries, > ), > ``` > > In this case the trigger probably should retry on any error though, to not make it overly complex, as other Tableau Operators / Sensors will also pass in retries. @eladkal what is your take? I would like to finish this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
