(airflow) branch main updated: Remove core imports in shared observability tests (#61784)

[amoghdesai]

This is an automated email from the ASF dual-hosted git repository.

amoghdesai pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new f2d4eef16cc Remove core imports in shared observability tests (#61784)
f2d4eef16cc is described below

commit f2d4eef16cc43d68908fd67c6632d8b97d4c3e63
Author: Amogh Desai <amoghrajesh1...@gmail.com>
AuthorDate: Thu Feb 12 12:28:06 2026 +0530

    Remove core imports in shared observability tests (#61784)
---
 .../tests/observability/metrics/test_stats.py      | 40 +++++++++++-----------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/shared/observability/tests/observability/metrics/test_stats.py 
b/shared/observability/tests/observability/metrics/test_stats.py
index 110c36bddc4..98f5ef24d54 100644
--- a/shared/observability/tests/observability/metrics/test_stats.py
+++ b/shared/observability/tests/observability/metrics/test_stats.py
@@ -30,14 +30,13 @@ import statsd
 import airflow_shared
 import airflow_shared.observability.metrics.stats
 import airflow_shared.observability.metrics.validators
-from airflow._shared.configuration import AirflowConfigException
-from airflow._shared.observability.metrics.validators import (
-    PatternAllowListValidator,
-    PatternBlockListValidator,
-)
 from airflow_shared.observability.exceptions import InvalidStatsNameException
 from airflow_shared.observability.metrics.datadog_logger import 
SafeDogStatsdLogger
 from airflow_shared.observability.metrics.statsd_logger import SafeStatsdLogger
+from airflow_shared.observability.metrics.validators import (
+    PatternAllowListValidator,
+    PatternBlockListValidator,
+)
 
 from tests_common.test_utils.config import conf_vars
 from tests_common.test_utils.markers import 
skip_if_force_lowest_dependencies_marker
@@ -149,7 +148,8 @@ class TestStats:
                 "Your custom StatsD client must extend the statsd."
                 "StatsClient in order to ensure backwards compatibility."
             )
-            with pytest.raises(AirflowConfigException, match=error_message):
+            # we assert for Exception here instead of AirflowConfigException 
to not import from shared configuration
+            with pytest.raises(Exception, match=error_message):
                 
airflow_shared.observability.metrics.stats.Stats.incr("empty_key")
         importlib.reload(airflow_shared.observability.metrics.stats)
 
@@ -166,9 +166,9 @@ class TestStats:
                 is_statsd_on=True,
                 is_otel_on=False,
             )
-            assert (
-                
type(airflow_shared.observability.metrics.stats.Stats.metrics_validator)
-                is PatternAllowListValidator
+            assert isinstance(
+                
airflow_shared.observability.metrics.stats.Stats.metrics_validator,
+                PatternAllowListValidator,
             )
             assert 
airflow_shared.observability.metrics.stats.Stats.metrics_validator.validate_list
 == (
                 "name1",
@@ -190,9 +190,9 @@ class TestStats:
                 is_statsd_on=True,
                 is_otel_on=False,
             )
-            assert (
-                
type(airflow_shared.observability.metrics.stats.Stats.metrics_validator)
-                is PatternBlockListValidator
+            assert isinstance(
+                
airflow_shared.observability.metrics.stats.Stats.metrics_validator,
+                PatternBlockListValidator,
             )
             assert 
airflow_shared.observability.metrics.stats.Stats.metrics_validator.validate_list
 == (
                 "name1",
@@ -215,9 +215,9 @@ class TestStats:
                 is_statsd_on=True,
                 is_otel_on=False,
             )
-            assert (
-                
type(airflow_shared.observability.metrics.stats.Stats.metrics_validator)
-                is PatternAllowListValidator
+            assert isinstance(
+                
airflow_shared.observability.metrics.stats.Stats.metrics_validator,
+                PatternAllowListValidator,
             )
             assert 
airflow_shared.observability.metrics.stats.Stats.metrics_validator.validate_list
 == (
                 "name1",
@@ -438,8 +438,8 @@ class TestPatternValidatorConfigOption:
             )
 
             assert 
isinstance(airflow_shared.observability.metrics.stats.Stats.statsd, 
statsd.StatsClient)
-            assert (
-                
type(airflow_shared.observability.metrics.stats.Stats.instance.metrics_validator)
 is expected
+            assert isinstance(
+                
airflow_shared.observability.metrics.stats.Stats.instance.metrics_validator, 
expected
             )
 
     @conf_vars({**stats_on, **block_list, ("metrics", "metrics_allow_list"): 
"baz,qux"})
@@ -453,9 +453,9 @@ class TestPatternValidatorConfigOption:
             )
 
             assert 
isinstance(airflow_shared.observability.metrics.stats.Stats.statsd, 
statsd.StatsClient)
-            assert (
-                
type(airflow_shared.observability.metrics.stats.Stats.instance.metrics_validator)
-                is PatternAllowListValidator
+            assert isinstance(
+                
airflow_shared.observability.metrics.stats.Stats.instance.metrics_validator,
+                PatternAllowListValidator,
             )
             assert "Ignoring metrics_block_list" in caplog.text