TopCoder2K commented on issue #49920: URL: https://github.com/apache/airflow/issues/49920#issuecomment-3889946204
Damn, I've found a bug: [this](https://github.com/apache/airflow/blob/f2d4eef16cc43d68908fd67c6632d8b97d4c3e63/providers/smtp/src/airflow/providers/smtp/hooks/smtp.py#L121) loop inside the `get_conn()` method isn't entered when `self.smtp_retry_limit == 0` (in the Web UI, I set "Number of Retries" to zero in order to better check connection problems). BUT! Here is another bug which added a headache to me: for some reason, the Web UI shows "Number of Retries" as 5 (instead of 0)! Since I forgot that I had set it to 0, I thought it was 5... In order to fix the first bug, it seems enough just to set the `range()` to start at 0 (since `self.smtp_retry_limit` is a number of **re**tries = repeated tries after the first try). Should I open a PR, @shahar1? And I look forward to any thoughts regarding the second bug (I'm very bad at frontend). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
