pierrejeambrun commented on code in PR #61279:
URL: https://github.com/apache/airflow/pull/61279#discussion_r2799321590


##########
airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_grid.py:
##########
@@ -874,6 +874,86 @@ def 
test_structure_includes_historical_removed_task_with_proper_shape(self, sess
         assert "is_mapped" not in t4
         assert "children" not in t4
 
+    def test_task_converted_to_taskgroup_doesnt_crash(self, session, 
test_client):

Review Comment:
   v1 and v2 should be inverted. This test is already working on main and 
doesn't need your code change to work. 
   
   
   On the other hand the bug appears when the task is a group, and then get 
transformed into a normal TI, and this is fixed by your code change. 
   
   Basically you need to invert Version 1 and Version 2 and we should be code. 
And adjust the code comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to