abhijeets25012-tech commented on code in PR #60070:
URL: https://github.com/apache/airflow/pull/60070#discussion_r2809739091
##########
providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py:
##########
@@ -1134,13 +1139,13 @@ def get_pandas_df( # type: ignore
return self._get_pandas_df(sql, schema=schema, hive_conf=hive_conf,
**kwargs)
@property
- def sqlalchemy_url(self) -> URL:
+ def sqlalchemy_url(self) -> "URL":
Review Comment:
Yes, you’re right — since URL is imported under if TYPE_CHECKING, using it
directly in the type hint works fine in modern Python (with from __future__
import annotations). We can remove the quotes around "URL" and just use URL
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
