dheerajturaga commented on PR #61946: URL: https://github.com/apache/airflow/pull/61946#issuecomment-3910325391
> > > Thanks for the detailed review @dheerajturaga! I've addressed all the feedback: > > > > 1. **Unit tests** — Added comprehensive `TestTaskInstanceOperations` test suite in `test_operations.py` with 6 tests covering all operations (`get`, `list`, `clear`, `clear_with_options`, `update`, `update_with_note`), following the XCom tests pattern from #61021. > > > > 2. **Integration tests** — Added `taskinstance clear` and `taskinstance update` integration tests in `test_airflowctl_commands.py`. > > > > 3. **`clear` output command** — Added `"clear"` to `output_command_list` in `cli_config.py`. > > > > 4. **Static code checks** — Ran `ruff` locally; all checks passed. > > > > All 6 unit tests pass locally. Let me know if there's anything else! > > Thanks for adding the tests! 😃 I see that the static checks are still failing. Just running ruff isn't enough, you would need to run the prek pre commit checks as mentioned in my earlier comment. Please give it a quick read. It should also automatically update the images for the airflowctl docs. I also see that the airflowctl checks are failing. Please address them as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
