potiuk commented on code in PR #62071: URL: https://github.com/apache/airflow/pull/62071#discussion_r2817260944
########## providers/google/pyproject.toml: ########## @@ -149,8 +147,7 @@ dependencies = [ # Any change in the dependencies is preserved when the file is regenerated [project.optional-dependencies] "apache.beam" = [ - 'apache-beam[gcp]>=2.53.0; python_version < "3.12"', - 'apache-beam[gcp]>=2.57.0; python_version >= "3.12"', + "apache-airflow-providers-apache-beam>=6.2.2", # use next version Review Comment: I think it's too limiting I think - the risk is small. Usually what will happen in this case, the user will have conflicts with earlier versions of beam and the only matching version will be the new one we are releasing now, so this is really not a big issue. BTW. What we do we have a cut-off time for provider dependencies and there is a prek hook that will automatically calculate min-version when we update pyproject.toml at release time: https://github.com/apache/airflow/blob/main/scripts/ci/prek/update_airflow_pyproject_toml.py#L71 (And you can override it there - but I do not think we need it) ########## providers/google/pyproject.toml: ########## @@ -149,8 +147,7 @@ dependencies = [ # Any change in the dependencies is preserved when the file is regenerated [project.optional-dependencies] "apache.beam" = [ - 'apache-beam[gcp]>=2.53.0; python_version < "3.12"', - 'apache-beam[gcp]>=2.57.0; python_version >= "3.12"', + "apache-airflow-providers-apache-beam>=6.2.2", # use next version Review Comment: I think it's too limiting - the risk is small. Usually what will happen in this case, the user will have conflicts with earlier versions of beam and the only matching version will be the new one we are releasing now, so this is really not a big issue. BTW. What we do we have a cut-off time for provider dependencies and there is a prek hook that will automatically calculate min-version when we update pyproject.toml at release time: https://github.com/apache/airflow/blob/main/scripts/ci/prek/update_airflow_pyproject_toml.py#L71 (And you can override it there - but I do not think we need it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
