dv-gorasiya commented on code in PR #61654:
URL: https://github.com/apache/airflow/pull/61654#discussion_r2818524327
##########
providers/google/src/airflow/providers/google/cloud/utils/credentials_provider.py:
##########
@@ -418,10 +418,7 @@ def _get_credentials_using_adc(self) -> tuple[Credentials,
str]:
scopes = list(self.scopes) if self.scopes else None
credentials, project_id = google.auth.default(scopes=scopes)
if not project_id:
- raise AirflowException(
- "Project ID could not be determined from default credentials. "
- "Please provide `key_secret_project_id` parameter."
- )
Review Comment:
You're right, the exception was added there as a mypy workaround rather than
intentional validation, so there were no existing tests covering that specific
raise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
