Miretpl commented on code in PR #62052:
URL: https://github.com/apache/airflow/pull/62052#discussion_r2818575044
##########
helm-tests/tests/helm_tests/apiserver/test_apiserver.py:
##########
@@ -76,6 +76,30 @@ def
test_should_add_volume_and_volume_mount_when_exist_api_server_config(self):
"readOnly": True,
} in jmespath.search("spec.template.spec.containers[0].volumeMounts",
docs[0])
+ def test_should_remove_replicas_field(self):
+ docs = render_chart(
+ values={
+ "airflowVersion": "3.0.0",
Review Comment:
I'm not a fan of `_get_values_with_version` despite having it in different
places in the helm tests, as it adds complexity to the test logic (when the
unit tests should rather not contain any). At the end, we can end up with as
much complexity as we have, e.g. in `security/test_rbac.py` or more, which
makes it harder to debug (in case of failures) and easier to miss not tested
cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
