o-nikolas commented on code in PR #61936:
URL: https://github.com/apache/airflow/pull/61936#discussion_r2819490402
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -56,6 +60,11 @@
from kubernetes.client.models import CoreV1Event, CoreV1EventList, V1Job,
V1Pod
LOADING_KUBE_CONFIG_FILE_RESOURCE = "Loading Kubernetes configuration file
kube_config from {}..."
+_AWS_EXEC_AUTH_VERSION_CHECK_MODE_FIELD =
"exec_auth_aws_cli_version_check_mode"
+_AWS_EXEC_AUTH_VERSION_CHECK_MODES = {"warn", "fail", "ignore"}
+_AWS_EXEC_AUTH_AWS_BINARY_NAMES = {"aws", "aws.exe", "aws2", "aws2.exe"}
+_AWS_EXEC_AUTH_FIXED_BOTOCORE_VERSION = (1, 40, 2)
+_BOTOCORE_VERSION_PATTERN =
re.compile(r"botocore/(?P<version>\d+(?:\.\d+){1,2})")
Review Comment:
Off the top of my head I can't think of previous case quite like this. Can
you @eladkal?
I see both sides, I don't like AWS stuff in the K8s hook, but I also see the
point @Vamsi-klu mentions. And the workaround sounds quite a bit more
complicated than the change already is, which I don't love :grimacing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
