SameerMesiah97 commented on PR #61830: URL: https://github.com/apache/airflow/pull/61830#issuecomment-3922843645
> thank you for raising PR Can you please send the screenshot of green system tests? Please find below the results of the system tests `example_compute.py `and `example_compute_recreate_drift.py` (this is a new test I have added): <img width="1173" height="64" alt="image" src="https://github.com/user-attachments/assets/5b8a9dca-3645-4f7e-80b2-ad7c74db0326"; /> <img width="1190" height="56" alt="image" src="https://github.com/user-attachments/assets/fa178f46-c211-4bf0-899e-488e9380b5f9"; /> Note that the failure indicated in the second screenshot is from another test `example_compute_igm.py`, and was unrelated to the changes introduced in the PR. It later succeeded when I re-ran it after deleting some Google Cloud resources. Please find below the screenshots proving this: <img width="1204" height="143" alt="image" src="https://github.com/user-attachments/assets/e7a3327c-0b63-45d1-900f-a100ecf59811"; /> <img width="940" height="40" alt="image" src="https://github.com/user-attachments/assets/e727ed06-9ab6-41e3-9f22-47b987a4641d"; /> Note that the first screenshot is the original image from which the results of example_compute.py and `example_compute_recreate_drift.py` have been cropped. Kindly tell me if this is sufficient for you. But keep in mind that these tests are rather flaky and take a very long time to run. I would appreciate assistance here with running them if you are able. > Please make sure to run also separately the case where the machine already exists, because current system test doesn't include this. As mentioned above, the new system test `example_compute_recreate_drift.py` should cover this scenario. > also correct me if i am wrong, this change is ONLY for the difference in machine type? no other parameters will be detected? That is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
