pierrejeambrun commented on code in PR #61679:
URL: https://github.com/apache/airflow/pull/61679#discussion_r2829304021
##########
airflow-core/src/airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -184,6 +193,12 @@ export const Variables = () => {
<HStack gap={4} mt={2}>
<ImportVariablesButton disabled={selectedRows.size > 0} />
<Spacer />
+ <ExpandCollapseButtons
+ collapseLabel = {translate("common:collapseAllExtra")}
+ expandLabel = {translate("common:expandAllExtra")}
Review Comment:
Tooltip isn't accurate. That mention "JSON" but it's not JSON.
<img width="774" height="387" alt="Image"
src="https://github.com/user-attachments/assets/1afd9a7b-6a97-4f57-9d34-a7f9affe25b2";
/>
You can instead use the generic "expand.collapse" and "expand.expand" keys.
##########
airflow-core/src/airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -78,17 +85,17 @@ const getColumns = ({
},
{
accessorKey: "key",
- cell: ({ row }) => <TrimText isClickable onClickContent={row.original}
text={row.original.key} />,
+ cell: ({ row }) => <TrimText isClickable onClickContent={row.original}
text={row.original.key}/>,
header: translate("columns.key"),
},
{
accessorKey: "value",
- cell: ({ row }) => <TrimText showTooltip text={row.original.value} />,
+ cell: ({ row }) => <TrimText showTooltip text={row.original.value}
charLimit={open? row.original.value.length : undefined}/>,
Review Comment:
Can you do the same for the 'description', see how it stays collapsed.
<img width="1014" height="708" alt="Image"
src="https://github.com/user-attachments/assets/8c5b3c24-f8c1-46ba-9597-a2ecf452ca66";
/>
##########
airflow-core/src/airflow/ui/src/pages/Variables/Variables.tsx:
##########
@@ -78,17 +85,17 @@ const getColumns = ({
},
{
accessorKey: "key",
- cell: ({ row }) => <TrimText isClickable onClickContent={row.original}
text={row.original.key} />,
+ cell: ({ row }) => <TrimText isClickable onClickContent={row.original}
text={row.original.key}/>,
header: translate("columns.key"),
},
{
accessorKey: "value",
- cell: ({ row }) => <TrimText showTooltip text={row.original.value} />,
+ cell: ({ row }) => <TrimText showTooltip text={row.original.value}
charLimit={open? row.original.value.length : undefined}/>,
header: translate("columns.value"),
},
{
accessorKey: "description",
- cell: ({ row }) => <TrimText showTooltip text={row.original.description}
/>,
+ cell: ({ row }) => <TrimText showTooltip
text={row.original.description}/>,
Review Comment:
formatting issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
