kaxil commented on code in PR #62128: URL: https://github.com/apache/airflow/pull/62128#discussion_r2834683254
########## airflow-core/src/airflow/dag_processing/manager.py: ########## @@ -36,7 +36,12 @@ from datetime import datetime, timedelta from operator import attrgetter, itemgetter from pathlib import Path -from typing import TYPE_CHECKING, Any, NamedTuple, cast +from typing import TYPE_CHECKING, Any, Literal, NamedTuple, cast + +if sys.version_info >= (3, 11): + from typing import assert_never +else: + from typing_extensions import assert_never Review Comment: You could move this to https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/typing_compat.py#L29-L32 ########## airflow-core/src/airflow/dag_processing/manager.py: ########## @@ -36,7 +36,12 @@ from datetime import datetime, timedelta from operator import attrgetter, itemgetter from pathlib import Path -from typing import TYPE_CHECKING, Any, NamedTuple, cast +from typing import TYPE_CHECKING, Any, Literal, NamedTuple, cast + +if sys.version_info >= (3, 11): + from typing import assert_never +else: + from typing_extensions import assert_never Review Comment: You could move this to https://github.com/apache/airflow/blob/ef5608204c8d039f2ef30f6d78617c0db26ac94c/airflow-core/src/airflow/typing_compat.py#L29-L32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
