shivaam commented on PR #62227: URL: https://github.com/apache/airflow/pull/62227#issuecomment-3939717675
> Agreed with @vincbeck's feedback. > > Also did you test these changes with the provided test case from #55678 ? It might even be worth adding a very similar if not identical test in this PR, to cover it at a higher level. Yes, I tested the change against the test case in the issue #55678 locally. I didnt include it as it will add dependency on `SQLValueCheckOperator` in the unit test. The existing test `test_init_ignores_unexpected_kwargs` replicates a similar scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
