stephen-bracken opened a new pull request, #62423:
URL: https://github.com/apache/airflow/pull/62423
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
The `S3RemoteLogIO` class was setting `use_threads=False` in the transfer
config arguments, but this argument is ignored if using the (now default)
`CRTTransferManager` instead of the `S3TransferManager`.
https://docs.aws.amazon.com/boto3/latest/reference/customizations/s3.html#s3-transfers
> use_threads – If True, threads will be used when performing S3 transfers.
If False, no threads will be used in performing transfers; all logic will be
run in the current thread. Note: This value is ignored when resolved transfer
manager type is CRTTransferManager. We noticed this because some of our tasks
which had very large log files were causing the worker pods in kubernetes to go
OOMKilled.
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
- [X] No
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
