potiuk commented on PR #62194: URL: https://github.com/apache/airflow/pull/62194#issuecomment-3953828335
> i think this is https://github.com/apache/airflow/blob/main/scripts/ci/prek/upgrade_important_versions.py#L391 Yes - if we automate min version upgrade - any time it happens, every contributor will get a failure when they are running prek hooks. That is heavily breaking the regular workflow of people. The approach I used so far is that we never "force" people to upgrade or build image, or sync uv. This either happens automatically (breeze upgrade - because it is fast) - or when you press `y` on image build (because it takes time). I believe - failng something that users wants to do, just to ask them to run upgrade (especially when it does not happen automatically) is a very, very bad UX. You either fix it automatically, or let it run with older version unless absolutely necessary. I think we should only upgrade min version of `prek` - when it is actually **needed** - because we need a new feature of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
