shahar1 commented on code in PR #61347:
URL: https://github.com/apache/airflow/pull/61347#discussion_r2855700129
##########
providers/google/src/airflow/providers/google/cloud/transfers/sheets_to_gcs.py:
##########
@@ -128,7 +142,11 @@ def execute(self, context: Context):
for sheet_range in sheet_titles:
data = sheet_hook.get_values(spreadsheet_id=self.spreadsheet_id,
range_=sheet_range)
gcs_path_to_file = self._upload_data(gcs_hook, sheet_hook,
sheet_range, data)
- destination_array.append(gcs_path_to_file)
+ if self.return_gcs_uris:
+ gcs_uri = f"gs://{self.destination_bucket}/{gcs_path_to_file}"
+ destination_array.append(gcs_uri)
+ else:
+ destination_array.append(gcs_path_to_file)
Review Comment:
Good call, not entirely sure why we need both return value as well as
`destination_objects` altogether since they return the same value, even without
the proposed changes. I think that the later should be deprecated to avoid
redundancy, unless someone couls justify it.
In any case, it's for another PR - for now I prefer that they will be
aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
