shahar1 commented on PR #61654: URL: https://github.com/apache/airflow/pull/61654#issuecomment-3979480405
> Hey @shahar1, finally got around to this, set up a real GCP project and ran actual DAGs against it. > > **Setup:** > - Created a fresh GCP project (`airflow-pr-test-61654`) with Secret Manager, BigQuery, and GCS APIs enabled > - Configured ADC via `gcloud auth application-default login` with **no quota project set**, so `google.auth.default()` returns `None` for `project_id`, this is what triggers the regression > - Ran Airflow locally with 3 test DAGs that each pass an explicit `project_id` > > ### BEFORE fix (regression on `main`) > > All 3 DAGs fail, `_get_credentials_using_adc()` raises `AirflowException` before the explicit `project_id` can be applied. > > **Secret Manager backend:** > > <img width="1000" height="1088" alt="before_sm" src="https://github.com/user-attachments/assets/d3081465-19dc-42f3-83b5-af6be0ee1f32"; /> > > **BigQuery hook:** > > <img width="1000" height="1070" alt="before_bq" src="https://github.com/user-attachments/assets/f8d172c6-020d-43ff-8b72-7d7453193b89"; /> > > **GCS hook:** > > <img width="1000" height="1070" alt="before_gcs" src="https://github.com/user-attachments/assets/3fc83586-34f4-4add-9d94-97a94cf2228d"; /> > > ### AFTER fix (this PR) > > Same DAGs, same GCP project, same ADC config. All 3 pass, the explicit `project_id` is honored. > > **Secret Manager backend:** > > <img width="1000" height="1106" alt="after_sm" src="https://github.com/user-attachments/assets/47717bee-d4f8-4901-859c-fff09c8d67ea"; /> > > **BigQuery hook:** > > <img width="1000" height="1142" alt="after_bq" src="https://github.com/user-attachments/assets/a00da4d4-3db4-49b0-a2e3-2fadf851b32b"; /> > > **GCS hook:** > > <img width="1000" height="1142" alt="after_gcs" src="https://github.com/user-attachments/assets/f69d9bb0-a3e0-4516-aeed-1b43dd5c1823"; /> Great, thanks! As I'm still on low availability, it will take me a long while to go over it properly. If you're certain of these changes, feel free to work on other PRs until I or someone else review it. @VladaZakharova @MaksYermak - I'll be happy if you could take a look as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
