jscheffl commented on code in PR #61039:
URL: https://github.com/apache/airflow/pull/61039#discussion_r2869282582
##########
chart/values.yaml:
##########
@@ -2309,6 +2309,39 @@ dagProcessor:
# classpath: "airflow.dag_processing.bundles.local.LocalDagBundle"
# kwargs: {}
+ # Per-bundle deployment option
+ # When enabled, creates a separate deployment for each bundle in
`dagBundleConfigList`
+ deployPerBundle:
+ enabled: false
+ # Command args template for per-bundle deployments
+ # `{{ bundleName }}` will be replaced with the actual bundle name
+ args: ["bash", "-c", "exec airflow dag-processor --bundle-name {{
bundleName }}"]
Review Comment:
Is there a reason that the args are populated? Which reasons would be there
to override this? Is it needed to expose this as (yet another) parameter?
##########
chart/values.yaml:
##########
@@ -2309,6 +2309,39 @@ dagProcessor:
# classpath: "airflow.dag_processing.bundles.local.LocalDagBundle"
# kwargs: {}
+ # Per-bundle deployment option
+ # When enabled, creates a separate deployment for each bundle in
`dagBundleConfigList`
+ deployPerBundle:
Review Comment:
I am not sure and would like opinions of other maintainers whether this
structure is well suited. It is fully arallel to the definition of the bundles
itself. Technically this is possilbe but then two lists need to be maintained
with a risk of inconsistency.
Is there a reason that you did not add the structure below the bundle list
definition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
