ashb commented on code in PR #62705:
URL: https://github.com/apache/airflow/pull/62705#discussion_r2873240186
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -1260,11 +1261,11 @@ def process_parse_results(
file_name = normalize_name_for_stats(Path(relative_fileloc).stem)
# bundle_name is included to distinguish files with the same name
across different bundles
normalized_bundle = normalize_name_for_stats(bundle_name)
-
Stats.timing(f"dag_processing.last_duration.{normalized_bundle}.{file_name}",
stat.last_duration)
- Stats.timing(
+ DualStatsManager.timing(
"dag_processing.last_duration",
stat.last_duration,
- tags={"file_name": file_name, "bundle_name": normalized_bundle},
+ tags={},
+ legacy_name_tags={"bundle_name": normalized_bundle, "file_name":
file_name},
Review Comment:
Oh. That's slightly confusing. The behabiour makes sense, but, just from the
callsite (of which there are going to be lots) it's a bit confusing that
legacy_name_tags gets applied to non-legacy metrics.
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
