o-nikolas commented on code in PR #62649:
URL: https://github.com/apache/airflow/pull/62649#discussion_r2874474834
##########
airflow-core/src/airflow/utils/helpers.py:
##########
@@ -295,6 +296,29 @@ def is_empty(x):
return val
+def filter_kwargs(callable_obj: Callable[..., Any], kwargs: dict) -> dict:
+ """
+ Filter kwargs to only include parameters the callable accepts.
Review Comment:
Yeah I hear that, but I think this feels like too much future proofing. We
shouldn't make a habit of injecting anything else in the future, and if we do,
tests will catch it and we can update this code then. But that's just my 2c,
happy to disagree and commit :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
