davlum commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S 
worker pod to be configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r357416853
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -372,7 +374,8 @@ def __init__(self,
         self.log.debug("Kubernetes using namespace %s", self.namespace)
         self.kube_client = kube_client
         self.launcher = PodLauncher(kube_client=self.kube_client)
-        self.worker_configuration = 
WorkerConfiguration(kube_config=self.kube_config)
+        # Parse the airflow.cfg once on AirflowKubernetesScheduler 
initialization
 
 Review comment:
   You're correct. I meant call the `make_pod` method once, as opposed to the 
current setup where it is called each time we call `run_next`. Seeing as the 
majority of `WorkerConfiguration` is tied to the `airflow.cfg` there is no need 
to call `make_pod` each time `run_next` is called as it is completely static. 
This relates to your above comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to