kaxil commented on code in PR #61461:
URL: https://github.com/apache/airflow/pull/61461#discussion_r2877246051
##########
airflow-core/src/airflow/serialization/encoders.py:
##########
@@ -200,19 +200,39 @@ def encode_deadline_alert(d: DeadlineAlert |
SerializedDeadlineAlert) -> dict[st
from airflow.sdk.serde import serialize
return {
- "reference": d.reference.serialize_reference(),
+ "reference": encode_deadline_reference(d.reference),
"interval": d.interval.total_seconds(),
"callback": serialize(d.callback),
}
+_BUILTIN_DEADLINE_MODULES = (
Review Comment:
Open question: is it intentional that legacy/core `ReferenceModels.*`
references are now outside the builtin set? If backwards compatibility is
desired, should this tuple include `"airflow.models.deadline"` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
