manipatnam commented on code in PR #62401:
URL: https://github.com/apache/airflow/pull/62401#discussion_r2880084435
##########
providers/cncf/kubernetes/docs/operators.rst:
##########
@@ -155,6 +155,35 @@ Example to fetch and display container log periodically
:end-before: [END howto_operator_async_log]
+Pod cleanup on kill
+^^^^^^^^^^^^^^^^^^^
+
+The ``cancel_on_kill`` parameter controls whether the Kubernetes pod is
deleted when a
Review Comment:
I saw a similar `cancel_on_kill` flag on BigQuery, Dataproc, and EMR
operators and followed that naming since it achieves the same functionality.
I feel a boolean is sufficient here -- `on_finish_action` needs an enum
because there are meaningfully different outcomes depending on pod state
(delete always, delete only succeeded, delete only active, keep). But
`cancel_on_kill` handles a separate flow where the user explicitly kills a
running task, so the pod is always in a non-terminal state. The action is
genuinely binary: delete it or leave it.
That said, I'm happy to change it to an enum if there's a concrete use case
that would benefit from it. I just don't see one right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
