pierrejeambrun commented on code in PR #62851: URL: https://github.com/apache/airflow/pull/62851#discussion_r2882875246
########## providers/fab/src/airflow/providers/fab/www/app.py: ########## @@ -46,6 +47,11 @@ app: Flask | None = None +if AIRFLOW_V_3_1_8_PLUS: + from airflow.api_fastapi.app import get_cookie_path +else: + get_cookie_path = lambda: "/" + # Initializes at the module level, so plugins can access it. Review Comment: Yeah we don't care about 'fab provider' backports, providers are released from main. But indeed we are missing the 'simple auth manager' part. (even if this is not production ready, it's weird that some file there are missing) ########## providers/amazon/src/airflow/providers/amazon/aws/auth_manager/routes/login.py: ########## Review Comment: same here, you can drop all the 'aws' providers change. It will make things simpler. Same for keycloak and fab provider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
