michotross257 opened a new pull request, #63167:
URL: https://github.com/apache/airflow/pull/63167
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Use pre-normalized conn type in `Connection.get_uri` when checking for the
presence of underscores.
When a connection is instantiated using a URI then the connection's
`conn_type` gets normalized via `Connection._normalize_conn_type` to replace
hyphens with underscores. If a conn type (e.g. `google-cloud-platform`)
contains hyphens then it will always generate the `Connection schemes (type:
%s) shall not contain '_' according to RFC3986.` warning in
`Connection.get_uri` whenever that method is called.
```python
from airflow.models import Connection
conn_uri = Connection(
conn_type="google-cloud-platform",
conn_id="test",
login="testlogin",
password="testpassword"
).get_uri()
print(Connection(conn_id="test", uri=conn_uri).get_uri())
```
**Output**:
```
Connection schemes (type: google_cloud_platform) shall not contain '_'
according to RFC3986. [airflow.models.connection.Connection]
loc=connection.py:269
google-cloud-platform://testlogin:testpassword@
```
Test can't account for a connection URI where the `conn_type` in the URI
contains underscores since in that case the `conn_type` will get incorrectly
parsed (which highlights a bug in connection URI parsing) and so the warning
will not be generated but not for the reason that we're checking for, e.g.
```python
from airflow.models import Connection
CONN_URIS = [
"google_cloud_platform://testlogin:testpassword@",
"google-cloud-platform://testlogin:testpassword@"
]
for conn_uri in CONN_URIS:
conn = Connection(conn_id="test", uri=conn_uri)
print("\n".join([
f"Conn URI: {conn_uri}",
f"Conn type: {conn.conn_type}",
f"Schema: {conn.schema}",
f"Login: {conn.login}",
f"Password: {conn.password}",
"=" * 20
]))
```
**Output**:
```
Conn URI: google_cloud_platform://testlogin:testpassword@
Conn type:
Schema: oogle_cloud_platform//testlogin:testpassword@
Login: None
Password: None
====================
Conn URI: google-cloud-platform://testlogin:testpassword@
Conn type: google_cloud_platform
Schema:
Login: testlogin
Password: testpassword
====================
```
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
