MonsterChenzhuo opened a new pull request, #63177:
URL: https://github.com/apache/airflow/pull/63177
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
Brief description of the changes.
- Fix an issue where task instance logs could become temporarily unavailable
after a failed try when the task transitions to UP_FOR_RETRY (or
UP_FOR_RESCHEDULE ).
- In this window, the log endpoint could return only the “Log message source
details” header without actual log content.
- Update FileTaskHandler to also attempt fetching served logs from the
worker log server for UP_FOR_RETRY / UP_FOR_RESCHEDULE states when no local or
remote logs are found.
Why this change is needed.
- UP_FOR_RETRY is treated as an “unfinished” state, so the existing logic
did not fetch served logs (which was only done for RUNNING / DEFERRED or
finished tasks), causing a gap where logs from the failed attempt were not
accessible until the next try started.
What was changed.
- In airflow-core/src/airflow/utils/log/file_task_handler.py , extend the
condition that triggers reading served logs to include
TaskInstanceState.UP_FOR_RETRY and TaskInstanceState.UP_FOR_RESCHEDULE .
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
