0x0OZ commented on code in PR #63161:
URL: https://github.com/apache/airflow/pull/63161#discussion_r2904921555
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py:
##########
@@ -60,8 +60,7 @@ def redact_extra(cls, v: str | None) -> str | None:
redacted_dict = redact(extra_dict)
return json.dumps(redacted_dict)
except json.JSONDecodeError:
- # we can't redact fields in an unstructured `extra`
- return v
+ return "***"
Review Comment:
True, there is no way to tell whether this extra is a secret or not,
I don't know if you prefer that it should be kept as is or should always be
redacted just in case, or maybe just keep it as is and add a note somewhere in
the documentation for the connection strings about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
