Crowiant opened a new pull request, #63181:
URL: https://github.com/apache/airflow/pull/63181
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
If a user does not set a job_id and the BigQueryInsertJobOperator fails with
a 429 error, the current retry logic will not work. This is because the
operator automatically generates the exact same job_id on every retry, which
triggers an AirflowException: 'Job already reached DONE state'.
Retry Logic added by this PR:
Note: The job_id should not be manually set by the user.
Attempt 1: The operator will create a BigQuery job using the provided
configuration and a job_id generated internally by the operator. If the job
finishes in a DONE state but with a "429 Too many requests" error in
error_result, the task will fail.
Attempt 2: The operator will generate the same job_id and submit it to the
BigQuery service, which will return a Conflict error. The operator will check
if the previous job's state is DONE and if its error_result contains the 429
error. If it does, a new job_id will be generated with the try_number appended
to the end, and the job will be resubmitted and executed. This logic also
allows the task to reattach to an existing BigQuery job in the case of an
Airflow component failure.
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
