Desel72 opened a new pull request, #63189:
URL: https://github.com/apache/airflow/pull/63189
Improve Playwright test patterns in `dag-runs-tab.spec.ts`
Replace anti-patterns in `DagRunsTabPage.ts` and `dag-runs-tab.spec.ts` with
Playwright best practices:
- Replace `page.locator('[data-testid="..."]')` with
`page.getByTestId("...")`
- Replace CSS `a[href...]` selectors with `getByRole("link")` locators
- Replace imperative `page.waitForURL()` with web-first
`expect(page).toHaveURL()`
- Replace `locator("tbody tr")` with `locator("tbody").getByRole("row")`
This PR focuses on improving test patterns only. It does not change test
coverage or behavior.
closes: #63165
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
