vatsrahul1001 commented on code in PR #63185:
URL: https://github.com/apache/airflow/pull/63185#discussion_r2905597251
##########
airflow-core/src/airflow/migrations/versions/0082_3_1_0_make_bundle_name_not_nullable.py:
##########
@@ -43,63 +43,62 @@
def upgrade():
"""Make bundle_name not nullable."""
+ import contextlib
+
+ # We need the DagBundlesManager here to respect and validate the user
configured bundles instead of hardcoding 'dags-folder' and 'example_dags' as
the only two bundles.
+ from airflow.dag_processing.bundles.manager import DagBundlesManager
Review Comment:
could we handle this in DagBundlesManager.sync_bundles_to_db() instead? It
already runs at startup with full config context before parsing begins, so we
could add a step there that reassigns any DAGs with a bundle_name not in the
current config to the first configured bundle. Would avoid touching migration
code altogether and also covers the case where someone renames a bundle later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
