Re: [PR] Improve translation completeness checker (required keys, coverage, unused) [airflow]

Mon, 09 Mar 2026 10:37:50 -0700 


andreahlert commented on PR #62983:
URL: https://github.com/apache/airflow/pull/62983#issuecomment-4025562257

   > Overall this looks great. One small suggestion: how about placing Coverage 
as the last column? It might be nice to keep Missing, TODOs, and Unused grouped 
together.
   > 
   > <img alt="Image" width="1006" height="1093" 
src="https://private-user-images.githubusercontent.com/54111883/559452089-49a26ef7-a0d4-496d-92c5-59c39421fb4e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMwNzc5MDEsIm5iZiI6MTc3MzA3NzYwMSwicGF0aCI6Ii81NDExMTg4My81NTk0NTIwODktNDlhMjZlZjctYTBkNC00OTZkLTkyYzUtNTljMzk0MjFmYjRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAzMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMzA5VDE3MzMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3YzY4NzZjNjBjZTU3NzYzYzVkYTA5ZWMzNDg5OWEwMzhlNjBlZGM2ZjAzOGFhZWY1YzRiMTgxOWEzNjk3NDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gtBk0IvKClrmkBjBbKsP4HeAT_q3N0kgYTd-Rl20ZKU";>
   
   In my humble opinion, when I am reading the table, coverage is the total at 
the moment. So TODO is the next step. For Exemple: 80% Coverage and 0 TODO, 
means that I really need to start.  If I put at the final column looks strange. 
Cause it is going to look like we are counting the TODO into coverage's sum. 
   
   Unused = discard, that's the main reason to be at the end. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to