potiuk commented on PR #62378: URL: https://github.com/apache/airflow/pull/62378#issuecomment-4026614727
> But I'm not sure if that's necessary. get_private_key() is essentially a private method (not marked as such, but end-users would not realistically ever call it) and it is only called once, so I modified the code at that point to be self.private_key = self.get_private_key() instead of setting self.private_key as a side-effect. Not necessary. This looks good :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
