YoannAbriel opened a new pull request, #63230:
URL: https://github.com/apache/airflow/pull/63230

   ## Problem
   
   `BigQueryAsyncHook._get_job()` calls `sync_hook.get_job()` synchronously 
inside an async method, blocking the event loop when running in triggers. This 
is a regression from #56363 which removed the `async_to_sync` wrapping but left 
the raw sync call in place.
   
   ## Root Cause
   
   `_get_job` awaits `get_sync_hook()` correctly, but then calls 
`sync_hook.get_job(...)` directly — a blocking I/O call that stalls the 
trigger's event loop.
   
   ## Fix
   
   Wrap the sync `get_job` call with `asgiref.sync_to_async` so it runs in a 
thread pool, consistent with how `GoogleBaseAsyncHook` handles other 
sync-to-async bridging (see `get_sync_hook`, `service_file_as_context`).
   
   Added a unit test verifying `sync_to_async` is called.
   
   Closes: #63182
   
   ---
   
   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code
   
   Generated-by: Claude Code following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to